Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session: add List[SocketOption] as param #558

Merged
merged 4 commits into from
Sep 22, 2022

Conversation

agustafson
Copy link
Contributor

We're having issues similar to #524, and thought that setting the keep-alive socket option might help to resolve that issue. This PR exposes the socket options as a param in Session.

@agustafson
Copy link
Contributor Author

FYI tested it out and adding SocketOption.keepAlive(true) didn't seem to solve the underlying BrokenPipe issue. Think this PR might still be useful.

@hnaderi
Copy link
Contributor

hnaderi commented Oct 6, 2021

@agustafson Can you describe the situation which this issue occurs? does it happen locally or on deployment?
Do you maintain long lived connections?
Is your deployment on docker swarm, k8s , ...?

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #558 (2b955cf) into main (5e3d234) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
+ Coverage   84.96%   84.98%   +0.01%     
==========================================
  Files         124      124              
  Lines        1643     1645       +2     
  Branches      109      133      +24     
==========================================
+ Hits         1396     1398       +2     
  Misses        247      247              
Impacted Files Coverage Δ
modules/core/shared/src/main/scala/Session.scala 55.22% <100.00%> (+1.37%) ⬆️
...re/shared/src/main/scala/net/BitVectorSocket.scala 100.00% <100.00%> (ø)
...red/src/main/scala/net/BufferedMessageSocket.scala 100.00% <100.00%> (ø)
...core/shared/src/main/scala/net/MessageSocket.scala 100.00% <100.00%> (ø)
...ules/core/shared/src/main/scala/net/Protocol.scala 81.25% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mpilquist mpilquist merged commit 0b9da5a into typelevel:main Sep 22, 2022
@mpilquist
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants