add read timeout #683
Merged
add read timeout #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Read and write socket timeouts were removed in #392. We could add read timeouts back if needed for health check queries though. Can we add some test coverage? |
svalaskevicius
force-pushed
the
read-timeout
branch
from
32811e2
to
741c556
Compare
|
@mpilquist yeah, I noticed that commit, and found no viable alternative means to recover the removed functionality - thus the PR :) I've rebased on main now, and added a test - please can you have a look? |
svalaskevicius
commented
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds read timeout for socket reads.
A reason to add it within the library rather than timing out skunk calls - it also applies for the healthcheck queries.