Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform SSL.Trusted #708

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

armanbilge
Copy link
Member

@armanbilge armanbilge commented Sep 22, 2022

fs2-io.js now supports insecure TLS context, so we can unplatform this code.

Ha, looks like I just missed the release train 😂 eh.

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #708 (d79b7ef) into main (7e85797) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #708   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files         124      124           
  Lines        1643     1643           
  Branches      114      109    -5     
=======================================
  Hits         1396     1396           
  Misses        247      247           
Impacted Files Coverage Δ
modules/core/jvm/src/main/scala/SSLPlatform.scala 0.00% <ø> (-11.12%) ⬇️
modules/core/shared/src/main/scala/SSL.scala 77.77% <100.00%> (+2.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mpilquist
Copy link
Member

If it makes you feel better, I'd have preferred this to go in a 0.4 release anyway :)

@armanbilge
Copy link
Member Author

Crap, bincompat. If a bump is likely this can just wait for that.

@mpilquist
Copy link
Member

Yeah, let's bump to 0.4 right after 0.3.2 is published

@armanbilge armanbilge closed this Sep 22, 2022
@armanbilge armanbilge reopened this Sep 22, 2022
@armanbilge armanbilge marked this pull request as ready for review September 22, 2022 02:47
@mpilquist mpilquist merged commit 5e3d234 into typelevel:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants