-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement per-session parsed statement cache #728
Conversation
7d7b5f2
to
9c6d435
Compare
Lacking some test for now, but opening it to review. |
So I ended up preserving the Still wondering about how many tests to add. Would a ParseCacheTest (based on the DescribeCacheTest) be sufficient ? |
Codecov Report
@@ Coverage Diff @@
## main #728 +/- ##
==========================================
- Coverage 87.18% 84.82% -2.37%
==========================================
Files 111 124 +13
Lines 1506 1667 +161
Branches 105 124 +19
==========================================
+ Hits 1313 1414 +101
- Misses 193 253 +60
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
An attempt to solve #496.
The parse statement cache is modeled after the Describe one in term of API / implementation and visibility.
I added handles to get all the data in cache in order to handle the session cleanup.
The cleanup is done at the
Protocol[F]
level.I finally decided to keep the
Parse.apply
inResource
to not break a lot of code, this could be handled as a follow up pr.Open to all suggestions :)