Misc fixes to allow local file to work with both Docker for Mac and C… #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Recheck |
armanbilge
reviewed
Mar 20, 2023
| ), | ||
| WorkflowStep.Run( | ||
| commands = List("docker-compose up -d"), | ||
| commands = List("export SERVER_KEY=$(cat world/server.key)", "export SERVER_CERT=$(cat world/server.crt)", "docker-compose up -d"), |
There was a problem hiding this comment.
Instead of export, should these be set as proper env = Map(...) variables for the WorkflowStep ?
There was a problem hiding this comment.
Oh, sorry, I see, they are reading from a file 🤔
Codecov Report
@@ Coverage Diff @@
## main #823 +/- ##
=======================================
Coverage 84.82% 84.83%
=======================================
Files 126 126
Lines 1727 1728 +1
Branches 196 202 +6
=======================================
+ Hits 1465 1466 +1
Misses 262 262 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…olima.
With this change, I'm able to run all the Docker containers in Colima short of the redshift one.