Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SocketGroup -> Resource[F, Socket[F]] #930

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

taig
Copy link
Contributor

@taig taig commented Jul 21, 2023

Closes #928

@codecov-commenter
Copy link

Codecov Report

Merging #930 (1b88a60) into main (bd59b9c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #930   +/-   ##
=======================================
  Coverage   83.68%   83.69%           
=======================================
  Files         127      127           
  Lines        1790     1791    +1     
  Branches      199      156   -43     
=======================================
+ Hits         1498     1499    +1     
  Misses        292      292           
Impacted Files Coverage Δ
modules/core/shared/src/main/scala/Session.scala 59.57% <100.00%> (+2.27%) ⬆️
...re/shared/src/main/scala/net/BitVectorSocket.scala 100.00% <100.00%> (ø)
...red/src/main/scala/net/BufferedMessageSocket.scala 96.15% <100.00%> (ø)
...core/shared/src/main/scala/net/MessageSocket.scala 100.00% <100.00%> (ø)
...ules/core/shared/src/main/scala/net/Protocol.scala 82.35% <100.00%> (ø)

@mpilquist mpilquist merged commit 4601638 into typelevel:main Jul 27, 2023
@taig taig deleted the socketgroup-to-sockets branch July 27, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax reliance on SocketGroup
3 participants