Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple unit tests are infinite-looping when running against scala 2.13 #778

Open
erikerlandson opened this issue Mar 16, 2019 · 3 comments

Comments

@erikerlandson
Copy link
Contributor

I disabled these in #759, with comments.

JoeWrightss pushed a commit to JoeWrightss/spire that referenced this issue Apr 13, 2019
…-in-systems-tests

Use locally built SPIRE images in systems tests
@gabrieljones
Copy link
Contributor

if (spire.scalacompat.preScala2p13) {
// this test inf-loops on scala 2.13
implicit val threshold = BigDecimal(1e-14) // 532788694 + 329i has log-error-ratio 1.1e-15
logNear(x.nroot(2).pow(2), x)
}

Found this one. Where are the others?

@gabrieljones
Copy link
Contributor

if (spire.scalacompat.preScala2p13) {
Gen.oneOf(
genRational.map { q => RationalAlgebraic(Algebraic(q), q) },
genBigDecimal,
genDouble,
genLong
)
} else {
// Scala 2.13 has bugs around the construction of BigDecimal quantities
Gen.oneOf(
genRational.map { q => RationalAlgebraic(Algebraic(q), q) },
genDouble,
genLong
)
}

Found a second reference to spire.scalacompat.preScala2p13

@kschwarz1116
Copy link
Contributor

Attempted to address since the issue linked from the PR is fixed, however I seem to be running into a similar issue with scala 3 instead. I wonder if that change never made it into dotty. I'll keep digging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants