Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci #1093

Merged
merged 5 commits into from
Oct 23, 2021
Merged

Fix ci #1093

merged 5 commits into from
Oct 23, 2021

Conversation

i10416
Copy link
Contributor

@i10416 i10416 commented Oct 22, 2021

fix #1092

TODO

  • validate documents
  • fix guide.md
  • fix index.md

- mdoc 2.2.24 supports scala 3.1.0
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this all up! Much appreciated 😁

docs/src/main/mdoc/index.md Outdated Show resolved Hide resolved
WorkflowStep.Sbt(List("doc"), name = Some("Build docs"))
WorkflowStep.Sbt(List("doc", "docs/mdoc"), name = Some("Build docs"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason we shouldn't just run docs/makeMicrosite, since this is exactly what the publish workflow is doing? That way we can be sure it will work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, unless that needs jekyll doesn't it? So then this is fine.

@armanbilge armanbilge merged commit 68aae27 into typelevel:main Oct 23, 2021
@armanbilge
Copy link
Member

Nice work!! Thank you!! http://typelevel.org/spire/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that site/docs build in CI, run for PRs
2 participants