Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename forbidUnknownValues to forbidObjectLiterals? #314

Open
jakobrosenberg opened this issue Feb 3, 2019 · 2 comments
Open

rename forbidUnknownValues to forbidObjectLiterals? #314

jakobrosenberg opened this issue Feb 3, 2019 · 2 comments
Labels
flag: BREAKING CHANGE Issues containing a breaking change, requiring a major release. type: documentation Issues related to improving the documentation. type: fix Issues describing a broken feature.

Comments

@jakobrosenberg
Copy link

Taken from the readme:

It's highly advised to enable on forbidUnknownValues what prevent unknown objects to pass validation.

I can't make sense of that. I read the parameter forbidUnknownValues as fodbidUndefinedProperties, but I know that's not what it means. Meanwhile the description refers to this unknownValues as unknownObjects and I wonder what it all means.

Are unknown values in actuality object literals?
@vlapo
Copy link
Contributor

vlapo commented Jun 23, 2019

Reference #305 as this option name is misleading.

But forbidObjectLiterals looks like not the best option. What about classes without properties with validation decorators? I would suggest forbidUnknownTargets or forbidUnknownSchemas or forbidUnknownClasses.

@vlapo vlapo added type: documentation Issues related to improving the documentation. and removed flag: needs discussion labels Apr 19, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

Hope it'll be implemented.

@NoNameProvided NoNameProvided added flag: BREAKING CHANGE Issues containing a breaking change, requiring a major release. type: fix Issues describing a broken feature. and removed type: refactor labels Aug 2, 2020
@pskopnik pskopnik mentioned this issue Mar 16, 2021
Closed
@roim roim mentioned this issue Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flag: BREAKING CHANGE Issues containing a breaking change, requiring a major release. type: documentation Issues related to improving the documentation. type: fix Issues describing a broken feature.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Clarify forbidUnknownValues roim/class-validator
3 participants
@vlapo @jakobrosenberg @NoNameProvided