Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify forbidUnknownValues #1355

Closed
wants to merge 243 commits into from
Closed

docs: Clarify forbidUnknownValues #1355

wants to merge 243 commits into from

Conversation

roim
Copy link

@roim roim commented Oct 20, 2021

Description

There's been some discussion for what exactly this is doing. It was also (incorrectly) suggested as a fix for #438

The docs are unclear (#314 #896) and full of grammar mistakes. This is an attempt to improve them based on what I understood from how it is implemented.

Checklist

  • [ X] the pull request title describes what this PR does (not a vague title like Update index.md)
  • [ X] the pull request targets the default branch of the repository (develop)
  • [ X] the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • [ X] tests are added for the changes I made (if any source code was modified)
  • [ X] documentation added or updated
  • [ X] I have run the project locally and verified that there are no errors

Fixes

fixes #314
fixes #896

dependabot bot added 30 commits March 23, 2021 17:40
dependabot bot added 18 commits October 4, 2021 08:15
@roim roim changed the title Expand docs for forbidUnknownValues docs: Clarify forbidUnknownValues Oct 20, 2021
@NoNameProvided
Copy link
Member

Landed in e252183.

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

rename forbidUnknownValues to forbidObjectLiterals? question: the forbidUnknownValues option has no effect
2 participants