Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct "an url" typo to "a url" #1713

Closed
wants to merge 102 commits into from

Conversation

Kareem-Medhat
Copy link

I did a quick search to to be certain and immediately found these websites that also
state that it is indeed written and pronounced as "a url":

Description

Changes all occurrences of "an url" to "a url" in changed files

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

As this is a typo fix I believe opening an issue isn't required as stated in the CONTRIBUTING.md file

(Some very minor changes like a typo fix may be opened without opening a tracking issue.)

dependabot bot and others added 21 commits March 7, 2022 09:09
I did a quick search to to be certain and found these websites that also
state that it is indeed written and pronounced as "a url":
- https://www.techtarget.com/whatis/feature/Which-is-correct-a-URL-or-an-URL
- https://www.quora.com/Which-is-correct-A-URL-or-An-URL
jotamorais pushed a commit to jotamorais/class-validator that referenced this pull request Oct 7, 2022
@NoNameProvided
Copy link
Member

Fixed in 9c6e5ac.

@NoNameProvided NoNameProvided added the status: superset by another Issue or task being tracked/handled in a different issue. label Nov 20, 2022
@NoNameProvided NoNameProvided changed the title Fix: typo where "a url" is written as "an url" fix: correct "an url" typo to "a url" Nov 20, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: superset by another Issue or task being tracked/handled in a different issue.
Development

Successfully merging this pull request may close these issues.

2 participants