-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display type correctly for array if obj passed as an array #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you! |
The merge of this pull request seems to break the CI workflow: https://github.com/typicode/json-server/actions/runs/4170357594/jobs/7219243004 It should probably be adjusted or reverted. |
typicode
pushed a commit
that referenced
this pull request
Feb 18, 2023
This was referenced May 24, 2024
Open
This was referenced Sep 12, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we pass an array instead of an object in the JSON file.
It throws an error like this;
Data must be an object. Found object.
which makes no sense.This happens because typeof operator returns 'object' if you pass an array as an operand.
So, we should use Array.isArray to determine whether the passed value is an array instead of using typeof operator. We can use typeof as a fallback.