this fixes /gorhill/httpswitchboard/issues/381

uBlock-LLC · Jul 23, 2014 · 66ea835 · 66ea835
1 parent 93d4513
commit 66ea835
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/js/assets.js b/js/assets.js
@@ -79,13 +79,18 @@ var cachedAssetsManager = (function() {
             return;
         }
         var onLoaded = function(bin) {
-            if ( chrome.runtime.lastError ) {
-                console.error(
-                    'µBlock> cachedAssetsManager> getEntries():',
-                    chrome.runtime.lastError.message
-                );
+            // https://github.com/gorhill/httpswitchboard/issues/381
+            // Maybe the index was requested multiple times and already 
+            // fetched by one of the occurrences.
+            if ( entries === null ) {
+                if ( chrome.runtime.lastError ) {
+                    console.error(
+                        'µBlock> cachedAssetsManager> getEntries():',
+                        chrome.runtime.lastError.message
+                    );
+                }
+                entries = bin.cached_asset_entries || {};
             }
-            entries = bin.cached_asset_entries || {};
             callback(entries);
         };
         chrome.storage.local.get('cached_asset_entries', onLoaded);

diff --git a/manifest.json b/manifest.json
@@ -2,7 +2,7 @@
     "manifest_version": 2,
     "name": "__MSG_extName__",
     "short_name": "µBlock",
-    "version": "0.2.3.4",
+    "version": "0.2.3.5",
     "description": "__MSG_extShortDesc__",
     "icons": {
         "16": "img/icon_16.png",