Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Chrome Mobile iOS" -> "Chrome Mobile" #481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

znarf
Copy link

@znarf znarf commented Jun 3, 2020

Seems "iOS" is duplicate with the os property and not necessary

seems that it's duplicate with the os property and not necessary
@Krinkle
Copy link

Krinkle commented Feb 7, 2021

I think iOS is significant to keep here. At least for the use cases I've had and seen around me, browser_family is generally used/evaluated/indexed on its own, not solely as tuple with os_family+device.

As such, the presence of "iOS" here, is effectively the only thing I can use to realize that this is WebKit/Safari and not Blink/Chrome. I think that's important to retain in statistics, at least until we formalise a proper "renderer" field (per #215).

@commenthol
Copy link
Contributor

Hi @znarf, Can you please provide a testcase?

@dgoldstein0
Copy link
Contributor

I agree with @Krinkle; browsers detected as Chrome are generally Blink-based, whereas Chrome on iOS is very much not, and so it's rare that I'd want to code to treat it the same as Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants