Annotation rendering configuration new section updates #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated annotation configuration, updated unit tests, partially updated system tests * updating the sidebar style to remained a fixed size, updated the logic for removing '_' from the anchors when displaying them * fixed system test & made the anchors have consistent naming style * added back the dataset data for each model * lint fix * unit test update * removed file upload where not needed * made requested PR changes, updating variant to hgvs_variant for attachment/genomic Type type, update styling to use variable set in main.css * Update frontend/src/models/analyses.js Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com> Signed-off-by: Alex Moss <kuthedk@users.noreply.github.com> * Update frontend/src/models/analyses.js Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com> Signed-off-by: Alex Moss <kuthedk@users.noreply.github.com> * Update frontend/src/models/analyses.js Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com> Signed-off-by: Alex Moss <kuthedk@users.noreply.github.com> * Update case_annotation_section_anchors.cy.js * Update frontend/src/models/analyses.js Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com> Signed-off-by: Alex Moss <kuthedk@users.noreply.github.com> --------- Signed-off-by: Alex Moss <kuthedk@users.noreply.github.com> Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com>
* Update Annotation Configuration to include new annotations from Alliance Genome (#81) * Now fetching the proper alliance genomic identifiers, with the correct identifiers the models are now being pulled in as expected * Create Animal Model Card to represent the animal models from Alliance Genome (#86) * Adding scrolling to the cards * Changed the model annotations to get a limit of 100 models, rather than 20 models. Updated the fixtures to contain ALL models * Removed display: block, position: relative from card-base. Changed li margin-left to use variable. Removed the overflow-y from card-source * Consolidated duplicate conditional code to determine if a section is empty and change the text color in AlliangeGenomeCard * Updated the AllianceGenomeCard.spec.js toContain to be to.include * Merged and updated for the new configuration to allign with the new datasets being introduced. --------- Signed-off-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com> Co-authored-by: James Scherer <jscherer@uab.edu>
…#89) * Created migration script file to add additional annotation sections * Migration script saving changes in database. Debugging comments removed * Update etc/fixtures/migrations/migrate-additional-sections.js Added suggestion to update section name to match configuration Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com> Signed-off-by: Rabab Fatima <fr.rabab@gmail.com> --------- Signed-off-by: Rabab Fatima <fr.rabab@gmail.com> Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com>
…pi docs (#91) * Updated the fixtures for CPAM0084 * Updated python tests
… animal models in the relevant section so I can have all the information consolidated in one location (#92) * Updated annotation configuration to have both automated and specificed alliance genome animal summaries, updated the fixtures to include both summaries and are accurate to the gene identifier, and updated the annotation rendering configuration to display the new annotations * Updated the python tests to include the 4 extra annotations in the configuration * updated the existing tests and removed the mongo ids from the imported fixtures * updated the existing tests and removed the mongo ids from the imported fixtures * Updated the Text Dataset in the Annotation components to display as unavailable if the value also has empty string * Updated the fixtures for genomic unit collection * Removed the mongoids from the genomic units collection initial seed
…m analyses, so they can be re-annotated with the correct information (#99) * Adding the remove annotation and annotation queueing scripts * Adding documentation and run feedback * Updated the analysis annotation script to give relevant output * Fixed the annotation config that broke annotation * Linting should be passing * Removed debugging print statements * Added a note to the annotate-all-existing-analyses.sh that it may need to be run more than once * Removed a space
…to visualize the HPO terms
…logo, header, and section anchor links' for now until we fix it
JmScherer
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
PR reviewed in meeting with @SeriousHorncat & @fatimarabab on 07/07/2023 @ 11:00am
SeriousHorncat
deleted the
annotation-rendering-configuration-new-section-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Pull Request Details
Wrike Ticket - Deployment Plan for Each of the branches
Changes made:
To Review:
Static Analysis by Reviewer
The migration script migrates the production installation works as intended/rendered correctly.
To check this run the following commands:
Download the archived production database to your local machine. See @SeriousHorncat for the URL to download it from Box.
Import the production database backup to Rosalution from the rosalution root directory
# ./etc/database/restore-database.sh <container name> <absolute-file-path-to-backup-archive> ./etc/database/restore-database.sh rosalution-rosalution-db-1 rosalution-db-2023-07-07-1688746774.archivedocker exec -it rosalution-rosalution-db-1 mongosh /tmp/fixtures/migrations/migrate-additional-sections.jsdocker cp ./etc/database/set-new-annotations-configuration.sh rosalution-rosalution-db-1:/tmp/fixtures/set-new-annotations-configuration.sh docker exec -it rosalution-rosalution-db-1 bash ./tmp/fixtures/set-new-annotations-configuration.sh -f /tmp/fixtures/initial-seed/annotations-config.json -b ./backup/docker exec rosalution-rosalution-db-1 mongosh /tmp/fixtures/remove-automatic-annotations.jsList any other checks needed to be reviewed.
All Github Actions checks have passed.