-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Branch] Analysis Discussion Section - Phase 1 #161
Commits on Nov 27, 2023
-
[Frontend] Create a new discussion component to be displayed in an An…
…alysis view (#139) * Updating the paper to include the country for each affiliation which is required for publication. * Updated the system tests workflow to use electron (#140) * Added a DiscussionsSection.vue in AnalysisView components, updated the analysis model to return an injected discussion object, and updating the styling of the buttons to match figma more closely * The discussion collapse works * Looks ready for a pull request * Tests should be working now * Left out the node test * Updating CSS in a few places * Updating the DiscussionSection values --------- Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2867937 - Browse repository at this point
Copy the full SHA 2867937View commit details -
Created a discussions property in each of the analyses with several p…
…osts within them. Removed the temp fixture used in the frontend (#141)
Configuration menu - View commit details
-
Copy full SHA for 5eb3b21 - Browse repository at this point
Copy the full SHA 5eb3b21View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad1bed5 - Browse repository at this point
Copy the full SHA ad1bed5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1adb132 - Browse repository at this point
Copy the full SHA 1adb132View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dd4d08 - Browse repository at this point
Copy the full SHA 6dd4d08View commit details -
Configuration menu - View commit details
-
Copy full SHA for b185d1f - Browse repository at this point
Copy the full SHA b185d1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f222ae7 - Browse repository at this point
Copy the full SHA f222ae7View commit details
Commits on Dec 1, 2023
-
Displaying discussion posts (#150)
* New Discussions post button, text field, and save/publish buttons * Creating temporary discussion API mock api endpoints to test integrating them into the frontend * Displaying posts from an analysis * Hooked up the discussion post to the backend and return a mock discussions post. Added styling to the discussion posts * Updated CSS to alternate discussion post colors * Added more unit test coverage on the frontend and linted * Added system tests and data-test attributes to go along with it --------- Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2c0f543 - Browse repository at this point
Copy the full SHA 2c0f543View commit details
Commits on Dec 5, 2023
-
[Frontend] Clicking the "New Discussion" button opens a field below t…
…he header line divider to enter an opinion (#151) * New Discussions post button, text field, and save/publish buttons * Displaying posts from an analysis * Added more unit test coverage on the frontend and linted * Toggles New Discussion Field * added system and unit tests for the discussion section * forgot to add the system test * Minor CSS fixes
Configuration menu - View commit details
-
Copy full SHA for 7d6036f - Browse repository at this point
Copy the full SHA 7d6036fView commit details
Commits on Dec 11, 2023
-
[Backend] Add a new route and repository to handle an incoming post a…
…nd save it in Mongo (#153) * Added a new collection to update a new post along with a test and linting * Fixing python unit test * Integration test and linting * Updated the analysis_collection add_discussion_post function to use pymongo find_one_and_update function to simplify how posts are added to discussions in analyses * linting
Configuration menu - View commit details
-
Copy full SHA for 954bfeb - Browse repository at this point
Copy the full SHA 954bfebView commit details
Commits on Dec 15, 2023
-
New migration script to ensure both supporting_evidence_files and dis…
…cussions keys are added to each analysis object in the analyses collection (#154)
Configuration menu - View commit details
-
Copy full SHA for e14d556 - Browse repository at this point
Copy the full SHA e14d556View commit details -
Updated phenotips importer to include supporting_evidence_files and d…
…iscussions field. Updated the analyses fixture to include these fields as well (#155)
Configuration menu - View commit details
-
Copy full SHA for 7fcd650 - Browse repository at this point
Copy the full SHA 7fcd650View commit details
Commits on Jan 12, 2024
-
Adding context menu to discussion posts (#156)
* added actions to the discussion post context menus * Changed the backend user object to send back the clientId in the basic user object, this is used to check if the user made a post and present a context menu * new ContextMenu.vue duplicates the DropDownMenu.vue functionality and turns it from hover to click. This is not quite right * lots of changes: swapped dropdown and contextmenu icons, contextmenu will now open on click and close when unfocused or an action is taken on the menu. ContextMenu styling changes * Fixed frontend test * Lots of fixes, trying to figure out how to test this * Frontend linting * Removed a .only in front end test
Configuration menu - View commit details
-
Copy full SHA for 006b10e - Browse repository at this point
Copy the full SHA 006b10eView commit details
Commits on Jan 22, 2024
-
[Backend] Remove and edit post route and methods to update and delete…
… a post from the discussion section (#157) * Added a delete route and delete post analysis collection function * Added a new route for editing a post and matching collection function, also added error checking for different situations in modifying discussion posts in an analysis * Change responsibilities of routes and put helper function to find discussion post in analysis model * proper error handling for discussion posts in progress * Removed the discussion fixtures and properly gets the discussion posts from the analysis * Finished integration and unit tests for updating and deleting a discussion post * Formatting/linting * Fixed integration test * Added unit and integration tests for analysis model and routers * Update backend/src/routers/analysis_discussion_router.py Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com> Signed-off-by: James Scherer <james.m.scherer@gmail.com> * Update backend/tests/integration/test_analysis_routers.py Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com> Signed-off-by: James Scherer <james.m.scherer@gmail.com> * linting --------- Signed-off-by: James Scherer <james.m.scherer@gmail.com> Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c663af1 - Browse repository at this point
Copy the full SHA c663af1View commit details
Commits on Jan 29, 2024
-
[Frontend] The vertical '...' context menu functions to delete posts (#…
…158) * Frontend discussion post deletion working, complete with notification dialog * Adding a system test for successfully deleting a new discussion post * fixing frontend unit tests and adding an extra system test * Linting * Changed the delete action in the context menu to have an emit key and chain the emits down the section to be called in the view to delete a post * Linting and changing var names * Lots of frontend unit tests, but not yet finished * Added more tests and linting * Fixed issue with contextId being renamed * Removed console log
Configuration menu - View commit details
-
Copy full SHA for 4371100 - Browse repository at this point
Copy the full SHA 4371100View commit details
Commits on Feb 5, 2024
-
[Frontend] The vertical '...' context menu functions to edit posts (#160
) * Frontend discussion post deletion working, complete with notification dialog * Adding a system test for successfully deleting a new discussion post * fixing frontend unit tests and adding an extra system test * Linting * Changed the delete action in the context menu to have an emit key and chain the emits down the section to be called in the view to delete a post * Linting and changing var names * Lots of frontend unit tests, but not yet finished * Added more tests and linting * Fixed issue with contextId being renamed * Removed console log * Edit post emit chain working and backend is saving properly, it's just the discussion content is the same as what's posted * Now editing a post works, it edits the post in place * More styling for the post editing * Frontend linting * Frontend tests and linting * Added system tests for post editing
Configuration menu - View commit details
-
Copy full SHA for 3219282 - Browse repository at this point
Copy the full SHA 3219282View commit details
Commits on Feb 8, 2024
-
Update .github/workflows/system-tests.yml
Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com> Signed-off-by: James Scherer <james.m.scherer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 045503c - Browse repository at this point
Copy the full SHA 045503cView commit details -
Update backend/src/routers/analysis_router.py
Co-authored-by: Angelina Uno-Antonison <ange.unoantonison@gmail.com> Signed-off-by: James Scherer <james.m.scherer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7c17049 - Browse repository at this point
Copy the full SHA 7c17049View commit details -
Configuration menu - View commit details
-
Copy full SHA for e39e555 - Browse repository at this point
Copy the full SHA e39e555View commit details