AllocationAttribute clean method exception handling #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current use of
literal_evalin coldfront.core.allocation.models.AllocationAttribute.clean causes the entry of a value with nonnumeric characters (e.g., "1000TB", "150%") for an AllocationAttribute with a numeric AllocationAttributeType to produce an EOF error. The code changes in this PR consist of the addition of smoother exception handling for such cases and unit tests for the AllocationAttribute model.I also deleted a few imports in the Allocation model module that weren't in use, and my code editor automatically removed trailing whitespace where present. Can remove those changes if they present problems.