Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nebula turf dependencies to the latest. #113

Closed
wants to merge 1 commit into from
Closed

Upgrade nebula turf dependencies to the latest. #113

wants to merge 1 commit into from

Conversation

romaxa
Copy link
Collaborator

@romaxa romaxa commented Oct 16, 2018

No description provided.

@supersonicclay
Copy link
Collaborator

supersonicclay commented Oct 16, 2018

Why? Since it is >=, a consuming application can use turf 6 today without any change to nebula.

@romaxa
Copy link
Collaborator Author

romaxa commented Oct 16, 2018

Why? Since it is >=, a consuming application can use turf 6 today without any change to nebula.

good question,

@romaxa romaxa closed this Oct 16, 2018
@romaxa
Copy link
Collaborator Author

romaxa commented Oct 16, 2018

I need to jump to latest turf-buffer, and >= does not jump over major version, so I endup with 2 turf-buffer versions in my bundle

yarn why @turf/buffer
yarn why v1.9.4
=> Found "@turf/buffer@5.1.5"
info Has been hoisted to "@turf/buffer"
=> Found "nebula.gl#@turf/buffer@4.6.1"
info Number of shared dependencies: 7

@supersonicclay
Copy link
Collaborator

I believe >= will jump over major versions. It is ~ and ^ that don't jump over major versions.

This is an issue with how yarn installs dependencies and sub-dependencies. I get around this by using yarn resolutions.
See this: yarnpkg/yarn#4986 (comment)
And this: https://yarnpkg.com/lang/en/docs/selective-version-resolutions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants