Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine previous changes on palette #473

Merged
merged 6 commits into from
Jul 27, 2021
Merged

Refine previous changes on palette #473

merged 6 commits into from
Jul 27, 2021

Conversation

edwinnglabs
Copy link
Collaborator

Description

this mainly fixes some of the issues from previous PR on palette changes.

Fixes # (issue)

  • remove uber_ in variable names
  • remove unnecessary code block and notebook, especially code blocks for debugging purpose
  • move style file to upper layer and for global usage (eda, diagnositc)
  • update some style from the file

More things needed in the future:

  1. try using the style in all tutorials
  2. an individual tutorial (maybe?) if we bring back some of the code how we should use it from Ariel?

@edwinnglabs edwinnglabs added review needed need someone to review refactor Issues to remove tech debt or improve design labels Jul 26, 2021
wangzhishi
wangzhishi approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@wangzhishi wangzhishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangzhishi wangzhishi merged commit 9b8570a into dev Jul 27, 2021
@wangzhishi wangzhishi deleted the feat-palette-more branch July 27, 2021 23:22
wangzhishi pushed a commit that referenced this pull request Aug 3, 2021
@wangzhishi
Refine previous changes on palette (#473)
65143fb 
* init

* style file

* small fix

* fix

* Update eda_orbit_style.ipynb

* Update backtest.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangzhishi wangzhishi wangzhishi approved these changes

@Ariel77 Ariel77 Awaiting requested review from Ariel77

Assignees
No one assigned
Labels
refactor Issues to remove tech debt or improve design review needed need someone to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwinnglabs @wangzhishi