Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev handle missing #645

Merged
merged 13 commits into from
Dec 17, 2021
Merged

Dev handle missing #645

merged 13 commits into from
Dec 17, 2021

Conversation

wangzhishi
Copy link
Contributor

@wangzhishi wangzhishi commented Dec 10, 2021 •
edited
Loading

  • ETS missing value handle
  • LGT missing value handle
  • DLT missing value handle
  • missing value example notebook
  • missing value unit test

@edwinnglabs edwinnglabs added review needed need someone to review tutorial labels Dec 13, 2021
@edwinnglabs
Copy link
Collaborator

edwinnglabs commented Dec 13, 2021 •
edited by wangzhishi
Loading

I made some enhance on the notebook @wangzhishi ; feel free to review it. follow up asks here:

  • add the example under exponential smoothing tutorial
  • add test cases with multiple missing values (you may have done this one already)
  • add test cases with consecutive missing values
  • add test cases with last missing values

@wangzhishi
Copy link
Contributor Author

I made some enhance on the notebook @wangzhishi ; feel free to review it. follow up asks here:

  • add the example under exponential smoothing tutorial
  • add test cases with multiple missing values (you may have done this one already)
  • add test cases with consecutive missing values
  • add test cases with last missing values

these test cases can be covered by one test case...

edwinnglabs
edwinnglabs approved these changes Dec 17, 2021
View reviewed changes
Copy link
Collaborator

@edwinnglabs edwinnglabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwinnglabs edwinnglabs merged commit 286002a into dev Dec 17, 2021
@edwinnglabs edwinnglabs deleted the dev-handle-missing branch December 17, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwinnglabs edwinnglabs edwinnglabs approved these changes

Assignees
No one assigned
Labels
review needed need someone to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangzhishi @edwinnglabs