Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edwin/logistic growth #712

Merged
merged 13 commits into from
Mar 8, 2022
Merged

Edwin/logistic growth #712

merged 13 commits into from
Mar 8, 2022

Conversation

edwinnglabs
Copy link
Collaborator

@edwinnglabs edwinnglabs commented Feb 28, 2022

Description

Please include a summary of the change and which issue is fixed.

#713

Type of change

Please delete options that are not relevant.

  • New feature
  • This change requires a documentation update

How Has This Been Tested?

Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests.

@edwinnglabs edwinnglabs added the review needed need someone to review label Mar 2, 2022
@edwinnglabs
Copy link
Collaborator Author

edwinnglabs commented Mar 7, 2022

some more reference about refreshing bsts data https://pydlm.github.io/example1.html#a-simple-model
@edwinnglabs can think about refresh the data back to 2004 if possible

revert back the logic of global linear and log-linear trend while keeping the new proposal for logistic trend
Copy link
Collaborator

@GavinSteiningerUber GavinSteiningerUber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
there will be another PR to add in a starting point for the logit

@wangzhishi wangzhishi merged commit a9dde27 into dev Mar 8, 2022
@wangzhishi wangzhishi deleted the edwin/logistic-growth branch March 8, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review needed need someone to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants