-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tqdm outlook #762
Merged
Merged
Fix tqdm outlook #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the tqdm outlook and slightly adjust the arg to make forecast and its child consistent.
This should fix the tqdm outlook and slightly adjust the arg to make forecast and its child consistent.
wangzhishi
approved these changes
Jun 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
edwinnglabs
added a commit
that referenced
this pull request
Nov 30, 2022
* v1.1.3dev * add python 3.8/3.9 to workflow (#752) * add python 3.8 to workflow * add python 3.9 to workflow * update * optimize interface (#755) * update residual diagnostic plots and example notebook (#758) * update residual diagnostic plots and example notebook * minor fix on unused import * diagnostic * Create residual_diagnostic.ipynb * temp * update * notebook update * Update plot.py * Update plot.py * Update plot.py * update * fix bug * update plot function * Update plot.py * Update model_diagnostics.ipynb * remove file * fixing lint problem * refreshing diagnostic notebook * Update plot.py * Update residual_diagnostic.ipynb Co-authored-by: Edwin Ng <edwinnglabs@gmail.com> * Fix tqdm outlook (#762) * init proposal This should fix the tqdm outlook and slightly adjust the arg to make forecast and its child consistent. * Update hyper_parameters_tuning.ipynb * init proposal This should fix the tqdm outlook and slightly adjust the arg to make forecast and its child consistent. * Update hyper_parameters_tuning.ipynb * a message added for ipywidgets * lint fix * Dev requirements fix (#763) * torch version update * release process update * minor code cleanup w/ Python 3 syntax (#765) * Edwin/some utils (#769) * Update stan.py * lint * Dev fix ktr (#771) * fix re-instantiation bug in KTR * tutorial update * fix re-instantiation bug in KTR * tutorial update * Add new utils (#778) * temp * adding new utils * Update general.py * Bug fix/numpy freeze (#783) * Update requirements.txt * Update build.yaml * Update build.yaml * Update build.yaml * Update build.yaml * Update ktr1.ipynb (#777) * Update ktr1.ipynb * Update ktr1.ipynb * global trend prior enhancement (#786) * global trend prior enhancement * lint reformatting * notebook refresh notebook refresh Co-authored-by: Zhishi Wang <zhishiw@uber.com> Co-authored-by: Zhishi Wang <wangzhishi@users.noreply.github.com> Co-authored-by: Ariel Jiang <ariel.jiang@uber.com> Co-authored-by: Jeong-Yoon Lee <jeongyoon.lee1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now orbit use case does not adapt the condition calling from terminal or notebook. See the solution suggested here
Fixes # (issue)
#750
Please delete options that are not relevant.
How Has This Been Tested?
Display checked from notebook only for now.