Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make twitter client be optional #1773

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

ishowvel
Copy link
Contributor

@ishowvel ishowvel commented Oct 24, 2024

Resolves #49

This pull requests enables the twitter client to be optional and not crash the devpool directory if env vars arent present for the twitter api

@0x4007
Copy link
Member

0x4007 commented Oct 24, 2024

Please rewrite your pull body to correctly link the pull to the issue. I'll need to fix CI another day!

Copy link
Contributor

Unused files (3)

.github/empty-string-checker.ts, .github/knip.ts, src/directory/set-state-changes.ts

Unused dependencies (1)

Filename dependencies
package.json octokit

Unused devDependencies (6)

Filename devDependencies
package.json @octokit/types
@types/jest
@types/twitter
esbuild
eslint-config-prettier
eslint-plugin-prettier

Unlisted dependencies (7)

Filename unlisted
.cspell.json @cspell/dict-typescript/cspell-ext.json
@cspell/dict-node/cspell-ext.json
@cspell/dict-software-terms
jest.config.json jest-md-dashboard
tests/helpers.test.ts @jest/globals
tests/twitter.test.ts @jest/globals
src/directory/directory.ts @octokit/plugin-rest-endpoint-methods

Unlisted binaries (2)

Filename binaries
.github/workflows/build.yml build
.github/workflows/cspell.yml format:cspell

@ishowvel
Copy link
Contributor Author

Done!

@0x4007 0x4007 merged commit b43c64e into ubiquity:development Oct 24, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Twitter Secrets Optional
2 participants