From 4fbe2f14f9171dc4bc8eabb29add44dda4beebe3 Mon Sep 17 00:00:00 2001 From: EresDev Date: Sun, 16 Jun 2024 15:43:51 +0500 Subject: [PATCH] fix: make tracking property optional --- tests/rpc-handler.test.ts | 9 ++++++++- types/handler.ts | 2 +- types/rpc-handler.ts | 2 +- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/rpc-handler.test.ts b/tests/rpc-handler.test.ts index 25611db..75d35c9 100644 --- a/tests/rpc-handler.test.ts +++ b/tests/rpc-handler.test.ts @@ -96,6 +96,9 @@ describe("RPCHandler", () => { yes: function (rpc: RpcType) { return true; }, + undefined: function (rpc: RpcType) { + return true; + }, }; for (const [trackingOption, filterFunction] of Object.entries(filterFunctions)) { @@ -111,7 +114,11 @@ describe("RPCHandler", () => { }); const rpcHandlerConfig = { ...testConfig }; - rpcHandlerConfig.tracking = trackingOption as Tracking; + if (trackingOption == "undefined") { + delete rpcHandlerConfig.tracking; + } else { + rpcHandlerConfig.tracking = trackingOption as Tracking; + } const handler = new RPCHandler(rpcHandlerConfig); await handler.testRpcPerformance(); const runtime = handler.getRuntimeRpcs(); diff --git a/types/handler.ts b/types/handler.ts index dafe301..035f089 100644 --- a/types/handler.ts +++ b/types/handler.ts @@ -38,7 +38,7 @@ export type HandlerConstructorConfig = { cacheRefreshCycles: number | null; runtimeRpcs: string[] | null; rpcTimeout: number | null; - tracking: Tracking; + tracking?: Tracking; }; export type NetworkRPCs = typeof networkRpcs; diff --git a/types/rpc-handler.ts b/types/rpc-handler.ts index 4f550c7..8bc2726 100644 --- a/types/rpc-handler.ts +++ b/types/rpc-handler.ts @@ -25,7 +25,7 @@ export class RPCHandler implements HandlerInterface { constructor(config: HandlerConstructorConfig) { this._networkId = config.networkId; - this._networkRpcs = this.filterNetworks(networkRpcsOriginal[this._networkId], config.tracking); + this._networkRpcs = this.filterNetworks(networkRpcsOriginal[this._networkId], config.tracking || "yes"); this._networkName = networkNames[this._networkId]; this._initialize(config); }