Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gated fsync kernel (matches coreos-stable) #234

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Conversation

m2Giles
Copy link
Member

@m2Giles m2Giles commented Aug 28, 2024

Thank you for contributing to the Universal Blue project!

Please read the Contributor's Guide before submitting a pull request.

@m2Giles m2Giles requested a review from castrojo as a code owner August 28, 2024 02:00
@@ -77,7 +80,11 @@ jobs:
export BUILDER_IMAGE=quay.io/fedora/fedora
echo "BUILDER_IMAGE=${BUILDER_IMAGE}" >> $GITHUB_ENV
echo "FQ_BUILDER_IMAGE=${BUILDER_IMAGE}:${{ matrix.fedora_version }}" >> $GITHUB_ENV
export KERNEL_IMAGE=${{ matrix.kernel_flavor }}-kernel
if [[ "${{matrix.kernel_flavor}}" != "fsync-gated" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little nitpicky, but why is this a negative? Isn't it a bit more clear to:

if [[ "${{matrix.kernel_flavor}}" == "fsync-gated" ]]; then
    export KERNEL_IMAGE=fsync-kernel
else
    export KERNEL_IMAGE=${{ matrix.kernel_flavor }}-kernel
fi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reason was that's just how I was thinking. I agree that not using the negative is better

Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is I struggle with the name 'fsync-gated' ... it does signify a delayed kernel release, but it doesn't connect much to the fact that we're matching the coreos-stable kernel version.

The thoughts I've had seem either too wordy or suffer from the same problem but just disconnecting another concept.

  • fsync-coreos-stable
  • fsync-coreos
  • fsync-stable
    ???

Thoughts on another name, or just leave it as is.

@bsherman
Copy link
Contributor

bsherman commented Aug 28, 2024

@m2Giles there was a comment made in Discord about the coreos-testing, zfs failure on fedora 40 builds failing... Just calling it out here... the fsync patches themselves don't seem to be conflicting with the zfs kmod build in 6.9. But 6.10 is failing the zfs kmod build even without fsync patches.

zfs 2.2.6 is pending release and will address 6.10 builds. openzfs/zfs#16472

@m2Giles
Copy link
Member Author

m2Giles commented Aug 28, 2024

For name I think fsync-coreos should get the idea across. fsync-coreos-stable would be clearer but unsure if we need that distinction

@bsherman
Copy link
Contributor

bsherman commented Sep 2, 2024

The one failing build now is just for coreos-testing-zfs, which will fail until openzfs releases version 2.2.6. This failure should not block merging of this PR.

@bsherman bsherman merged commit b82bf6d into main Sep 2, 2024
51 of 52 checks passed
@bsherman bsherman deleted the fsync-coreos-stable branch September 2, 2024 16:29
bsherman added a commit that referenced this pull request Oct 6, 2024
This reverts commit b82bf6d.

We have determined that CoreOS kernel releases and fsync kernel builds
do not reliably align so this is a bad approach.

Relates: #234
Relates: #237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants