-
Notifications
You must be signed in to change notification settings - Fork 23
feat: ease customization by reading flatpaks and rpms to install from a recipe.yml. #79
Conversation
a303b45
to
bf9def4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the point of setup-flatpaks is but I kept in intact instead of replacing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I need some time to test this in a VM, and I think by default we don't want the user to end up with layered packages though. We should probably have the rpm-ostree install command do an external list so that they end up with a complete image, but that can be done later.
This original pass was wonderful. For brevity of time and speed to land this I've made a few tweaks that would normally go in a review cycle - lets get this in asap.
I've made a few tweaks to this PR - mainly using yq to simplify looping logic and some file name preferences. Love this approach - thanks for the contribution! |
(sorry for all the noise, this has forced us to figure out how to do builds with PRs, in progress) |
Cheers! I thought dasel would be better/easier to install as yq uses python, but I'm fine with either. Your small change to the looping logic could have probably been done using dasel's |
yq is built in go and doesn't have any python packaged requirements
I didn't see that originally, I'd have to look to make sure. I'm far more familiar with jq/yq style jmespath lookup syntax |
Okay, a PR build is available. Going to do some quick tests and wait for @castrojo's feedback https://github.com/ublue-os/base/pkgs/container/base/73834831?tag=pr-79 |
wh- ahh both go then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in a clean VM, everything works just as before and the final state is what we want, nice work everyone!
This leverages shell scripting and https://github.com/TomWright/dasel to read the list of packages to install in ublue-firstboot and the containerfile.
If in the future another firstboot solution is used it could either read from this recipe.yml or just the firstboot-related things be split off.
Of course if desired this recipe.yml could also host other configuration options.