-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reorganize repo for Aurora builds #1091
Conversation
build_files/base/build.sh
Outdated
|
||
. /tmp/build/copr-repos.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be good to just run this in a for
loop over all .sh files in the directory?
We can prefix the names with numbers to control the execution order
If you prefer it as-is, I'm okay with that too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could also work. With this method, we can inline things like that singular rpm-ostree install. But I like the loop method to make us more purposeful with changes. I personally like this source method to not worry about the +x bit.
# Copy Bluefin CLI packages | ||
COPY --from=ghcr.io/ublue-os/bluefin-cli /usr/bin/atuin /usr/bin/atuin | ||
COPY --from=ghcr.io/ublue-os/bluefin-cli /usr/share/bash-prexec /usr/share/bash-prexec | ||
# COPY ublue kmods, add needed negativo17 repo and then immediately disable due to incompatibility with RPMFusion | ||
COPY --from=ghcr.io/ublue-os/akmods:${AKMODS_FLAVOR}-${FEDORA_MAJOR_VERSION} /rpms /tmp/akmods-rpms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope for this PR, but a thought - would it be good to move this to scripts too, and use skopeo or similar to extract these files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be nicer. We could remove a few of these COPY layers with that.
Reorganization of repo in order to support Aurora.
Containerfile restructured to remove inline shell. Instead everything is built out of sourced shell files in
/tmp/build
This is still a work in progress. The github actions need to be updated.