Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not set SSH_ASKPASS_REQUIRE in Aurora #1210

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

m2Giles
Copy link
Member

@m2Giles m2Giles commented Apr 26, 2024

#1208

SSH_ASKPASS should only be prompted when the user does not have a terminal. Otherwise, if /usr/bin/ksshaskpass isn't available it won't fall back to the terminal for input. To trigger ksshaskpass from the cmdline, use ssh-add < /dev/null

@m2Giles m2Giles requested a review from castrojo as a code owner April 26, 2024 21:18
Copy link
Member

@p5 p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure what this does, but it doesn't look bad

@castrojo castrojo merged commit 95dd578 into main Apr 26, 2024
30 of 32 checks passed
@castrojo castrojo deleted the remove-ssh-askpass-require branch April 26, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants