Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx image needs fonts #235

Closed
castrojo opened this issue May 26, 2023 · 10 comments
Closed

dx image needs fonts #235

castrojo opened this issue May 26, 2023 · 10 comments
Labels
dx Developer Experience Image specific help wanted Keep Bluefin alive, dive in!

Comments

@castrojo
Copy link
Member

I'd like to get a few nice fonts in the developer experience image,

[ ] Source Code Pro
[ ] Intel Mono

And a few others, feel free to suggest and PR them. I'm thinking something like top 10 of our favorite mono fonts

@castrojo castrojo added help wanted Keep Bluefin alive, dive in! dx Developer Experience Image specific labels May 26, 2023
@bsherman
Copy link
Contributor

[ ] Hack - source-foundry-hack-fonts
[ ] Fira Code - fira-code-fonts

@castrojo
Copy link
Member Author

For the non-packaged ones we should make sure we're pulling from an upstream so they can stay up to date without us having to manually do it.

@bsherman
Copy link
Contributor

For the non-packaged ones we should make sure we're pulling from an upstream so they can stay up to date without us having to manually do it.

That's just Intel Mono at this point, right?

adobe-source-code-pro-fonts exists.

@190n
Copy link
Contributor

190n commented May 26, 2023

It would be lovely to include Nerd Font variants, but that might be trickier due to packaging. There seems to be a third-party repository "Terra" which contains many of them, but I haven't heard of that before so I'm not sure if it is a commonly-used repository or anything. As for font recommendations:

[ ] Iosevka
[ ] JetBrains Mono - jetbrains-mono-fonts (but that package is not the nerd variant, see above)
[ ] IBM Plex Mono - ibm-plex-mono-fonts

@castrojo
Copy link
Member Author

Great idea! We've used the terra repo before here and I've chatted with some of them so I'll take a look, our nerd font game needs to be top notch!

IBM Plex Mono is already included. I should have included what it's in there already, which is:

cascadia-code-fonts
google-droid-sans-mono-fonts
google-go-mono-fonts
ibm-plex-mono-fonts
mozilla-fira-mono-fonts

@bsherman
Copy link
Contributor

My only concern with terra repo is some intermittent reliability. I've added and removed it from my custom image twice.

I really like what they have going on though, so maybe we could figure out why and it would be better for everyone.

@castrojo
Copy link
Member Author

Yeah I've done the same thing, there's good stuff in here though so I'm going to give it a shot. Inprogress here: #239

@castrojo
Copy link
Member Author

OK what do people think now? The font list in my terminal looks busy and I can see that some of these are renamed versions. Sauce Code Pro? 🙄

I'm kind of leaning towards official versions for that reason and then punting the rest to the user (we include a font downloader in the core apps).

@bsherman
Copy link
Contributor

I tend towards official fonts, from official repos. If IntelMono is a need, find a good way to add it, but it's still "official".

Need Fonts are cool, but even for developers, I think we tend to just need the one nerd font for the terminal, and only in specific cases, so I support leaving those to a font downloader.

@castrojo
Copy link
Member Author

castrojo commented Jun 7, 2023

Ok enough of these are in where I'm going to close this, if anyone has any other requests then open an issue!

@castrojo castrojo closed this as completed Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience Image specific help wanted Keep Bluefin alive, dive in!
Projects
None yet
Development

No branches or pull requests

3 participants