Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: incus enable script #759

Merged
merged 11 commits into from
Dec 29, 2023
Merged

feat: incus enable script #759

merged 11 commits into from
Dec 29, 2023

Conversation

bketelsen
Copy link
Member

Adds interactive shell script to enable Incus on bluefin-dx

p5
p5 reviewed Dec 28, 2023
View reviewed changes
Copy link
Member

@p5 p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bash wizard, so would like someone else to check over this, but mostly LGTM.

Added a few comments though on some stuff I am not too sure about.

dx/usr/bin/bluenfin-incus Outdated Show resolved Hide resolved
dx/usr/bin/bluenfin-incus Outdated Show resolved Hide resolved
@bketelsen bketelsen marked this pull request as ready for review December 29, 2023 01:59
EyeCantCU
EyeCantCU previously approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great as is but I've left a couple comments. I think it would be best to ship the script solely on DX and implement the logic for determining whether or not to rebase in the script added to the justfile instead of handling it in the main script

dx/usr/bin/bluefin-incus Outdated Show resolved Hide resolved
just/custom.just Show resolved Hide resolved
@bketelsen
Copy link
Member Author

@p5 @EyeCantCU Please take another look, comments resolved.

p5
p5 approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@p5 p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EyeCantCU
EyeCantCU approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic!

@bketelsen bketelsen added this pull request to the merge queue Dec 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 29, 2023
@EyeCantCU EyeCantCU added this pull request to the merge queue Dec 29, 2023
Merged via the queue into main with commit c40eff7 Dec 29, 2023
34 checks passed
@EyeCantCU EyeCantCU deleted the incus-enable branch December 29, 2023 15:36
@github-actions github-actions bot mentioned this pull request Dec 29, 2023
Merged
@github-actions github-actions bot mentioned this pull request Feb 26, 2024
Merged
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
@bketelsen
feat: incus enable script (ublue-os#759)
786bb0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p5 p5 p5 approved these changes

@EyeCantCU EyeCantCU EyeCantCU approved these changes

@castrojo castrojo Awaiting requested review from castrojo castrojo is a code owner

@bobslept bobslept Awaiting requested review from bobslept

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bketelsen @EyeCantCU @p5