-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct ulimit nofile issue with brew #988
Conversation
`brew install texlive` was still failing with: `Error: Too many open files @ rb_sysopen` This sets a functional limits.conf soft nofile limit of 4096, but also sets the same default in systemd/user.conf which is required for the ulimit value to be respected in terminals running under Wayland/Xorg. Relates: #670
🛌 |
Is my fix wrong? |
Soft limit gets overridden by systemd, so your fix only applies to the hard limit which this isn't affected by. |
I did some testing because there were still reports of the error in PR description/commit message. I didn't realize there had already been commits to address it, but no, sadly, your fix had not resolved the issue. Your fix worked for a user logged in at a console tty or via SSH 😀, but not for users using Bluefin's default bash shell via Ptyxis or gnome-terminal under gnome. I discovered that in this scenario, systemd is playing a primary role setting In addition, it seems slightly dangerous to raise the soft limit to equal the hard limit, so I did remove those lines in the brew-limits.conf. |
* fix: Assure that "disabling CoreDump tweak" is applied correctly Since Fedora uses systemd, we need to make this change too, else it won't be applied throughout the system, but only in SSH/TTY sessions. Bluefin had the same issue with open-file limits tweak here: ublue-os/bluefin#988 I usually put those config overrides to `/usr/lib`, but I will put them in `/usr/etc` to comply with the project's structure. As far as I look, this is the only tweak which needs this systemd conf change. * fix: Assure that "disabling CoreDump tweak" is applied correctly Since Fedora uses systemd, we need to make this change too, else it won't be applied throughout the system, but only in SSH/TTY sessions. Bluefin had the same issue with open-file limits tweak here: ublue-os/bluefin#988 I usually put those config overrides to `/usr/lib`, but I will put them in `/usr/etc` to comply with the project's structure. As far as I look, this is the only tweak which needs this systemd conf change. Signed-off-by: fiftydinar <65243233+fiftydinar@users.noreply.github.com> --------- Signed-off-by: fiftydinar <65243233+fiftydinar@users.noreply.github.com>
brew install texlive
was still failing with:Error: Too many open files @ rb_sysopen
This sets a functional limits.conf soft nofile limit of 4096, but also sets the same default in systemd/user.conf which is required for the ulimit value to be respected in terminals running under Wayland/Xorg.
Relates: #670