Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(just): restrict topgrade to only supported things #1916

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

tulilirockz
Copy link
Collaborator

@tulilirockz tulilirockz commented Nov 10, 2024

This is much more of a RFC than anything concrete, I just wanted to really know what you guys feel like should be directly supported by bluefin (and thus should be added to this only array). Restricting topgrade on ujust update should mitigate issues like #1912 and #1845

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 10, 2024
@tulilirockz
Copy link
Collaborator Author

Brew shouldnt need to be added there since it automatically updates upon running brew (anything). Although it could be a nice idea to automatically update that since maybe users use that very sparringly and they'll have like gigantic updates when theyre trying to install something on brew after a bit of time

@m2Giles
Copy link
Member

m2Giles commented Nov 10, 2024

Brew shouldnt need to be added there since it automatically updates upon running brew (anything). Although it could be a nice idea to automatically update that since maybe users use that very sparringly and they'll have like gigantic updates when theyre trying to install something on brew after a bit of time

brew auto updates with our brew-update services.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 10, 2024
@castrojo castrojo added this pull request to the merge queue Nov 10, 2024
Merged via the queue into ublue-os:main with commit 81fa662 Nov 10, 2024
42 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants