Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sddm): add mount unit for installing sddm themes in Discover #1944

Merged
merged 5 commits into from
Nov 23, 2024
Merged

feat(sddm): add mount unit for installing sddm themes in Discover #1944

merged 5 commits into from
Nov 23, 2024

Conversation

RealVishy
Copy link
Contributor

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Nov 18, 2024
tulilirockz
tulilirockz reviewed Nov 19, 2024
View reviewed changes
system_files/kinoite/usr/lib/systemd/system/usr-share-sddm-themes.mount
Type=overlay
What=overlay
Where=/usr/share/sddm/themes
Options=lowerdir=/usr/share/sddm/themes,upperdir=/var/sddm_themes/themes,workdir=/var/sddm_themes/themes.work
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably mount also should probably automatically create that /var/sddm_themes directory too tho, else it'll be mounting a non-existant folder :p

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added mkdir command to create the the working directory and the normal directory, I also ended up removing the PartOf= section since we don't want to recreate the bazzite target

m2Giles
m2Giles reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@m2Giles m2Giles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at making a symlink to a directory in /etc

Right now this PR won't actually work and has the possibility of failing due to not making sure that /var is mounted as well.

build_files/base/07-base-image-changes.sh Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work. You can use a tpmfiles.d conf file to make this directory after boot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the one used for the kde-sysmonitor workaround?

system_files/kinoite/usr/lib/systemd/system/usr-share-sddm-themes.mount
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also requires mounts for /var

@tduck973564
Copy link

It would be nice if this could be resolved upstream. Something for me to do, maybe.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 23, 2024
@castrojo castrojo added this pull request to the merge queue Nov 23, 2024
Merged via the queue into ublue-os:main with commit c5f467c Nov 23, 2024
42 checks passed
@tduck973564 tduck973564 mentioned this pull request Nov 24, 2024
Closed
@RealVishy RealVishy deleted the vishy-feature branch November 24, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulilirockz tulilirockz tulilirockz approved these changes

@m2Giles m2Giles m2Giles approved these changes

@castrojo castrojo castrojo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RealVishy @tduck973564 @castrojo @m2Giles @tulilirockz