Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 586: Warn of prior disjointedness declarations in core: and types: #587

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Issue 586: Warn of prior disjointedness declarations in core: and types: #587

merged 2 commits into from
Jun 5, 2024

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Feb 1, 2024 •
edited
Loading

This Pull Request resolves all backwards-compatible requirements of Issue #586 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop
  • CI passes in UCO current unstable branch (81af3ab)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (743a087)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

@ajnelson-nist
Warn of prior disjointedness declarations in core: and types:
e6dba28 
A follow-on patch will regenerate Make-managed files.

References:
* #586

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Regenerate Make-managed files
9460e74 
References:
* #586

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist added this to the UCO 1.4.0 milestone Feb 1, 2024
@ajnelson-nist ajnelson-nist linked an issue Feb 1, 2024 that may be closed by this pull request
Disjointedness already denoted in UCO should be enforced #586
Closed
15 tasks
@ajnelson-nist ajnelson-nist mentioned this pull request Feb 1, 2024
Closed
15 tasks
@ajnelson-nist ajnelson-nist marked this pull request as ready for review June 4, 2024 11:54
@ajnelson-nist
Copy link
Contributor Author

This PR is ready for review and merge.

@ajnelson-nist ajnelson-nist requested a review from a team June 4, 2024 11:54
plbt5
plbt5 reviewed Jun 5, 2024
View reviewed changes
ontology/uco/types/types.ttl
@@ -213,6 +224,17 @@ types:ThreadItem
] ;
.

types:ThreadItem-disjointWith-co-ListItem-shape
a sh:NodeShape ;
sh:message "types:ThreadItem and co:ListItem are disjoint classes. Assigning both types to a single node will be an error in UCO 2.0.0."@en ;
Copy link
Contributor

@plbt5 plbt5 Jun 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... will be an error as of UCO 2.0.0"

@plbt5 plbt5 merged commit f2b11ce into develop Jun 5, 2024
1 check passed
@plbt5 plbt5 deleted the Feature-Issue-586 branch June 5, 2024 14:44
@ajnelson-nist ajnelson-nist mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
Change Proposal
Projects
None yet
Milestone
UCO 1.4.0
Development

Successfully merging this pull request may close these issues.

Disjointedness already denoted in UCO should be enforced
2 participants
@ajnelson-nist @plbt5