Skip to content

Commit

Permalink
#444 - fix (manual) to Deprecation Warning. Should be handled later w…
Browse files Browse the repository at this point in the history 
…ith #446
  • Loading branch information
@antonkorotkov
antonkorotkov committed Feb 24, 2020
1 parent a28d0aa commit 486c901
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/Google/src/Google/Service/Resource.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ public function createRequestUri($restPath, $params)
}

if (count($queryVars)) {
$requestUrl .= '?' . implode($queryVars, '&');
$requestUrl .= '?' . implode('&', $queryVars);
}

return $requestUrl;
Expand Down

3 comments on commit 486c901

@jimyaghi
Copy link

@jimyaghi jimyaghi commented on 486c901 Mar 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i actually meant to make the issue report over at Google's repository. i think it's probably a better idea to just have them fix it there, then we don't make manual changes to their lib.

@jimyaghi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Google has taken care of it in version 2.4.1 of the PHP library. I would suggest including that version here and do it in composer instead of having its own weird lib directory. This way we can stay up to date with their latest changes.

@planv
Copy link
Contributor

@planv planv commented on 486c901 Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimyaghi
It will be done on issue #446

Please sign in to comment.