Remove old/obsolete suites (CPT_v0, GSD_v0, GSD_SAR) from workflow #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.sh script generates (by checking the status of the WE2E tests in a given directory).
…unity subdirectory (category) those tests that use the GSD_SAR suite.
…unity subdirectory (category) those tests that use the CPT_v0 and GSD_v0 suites.
…the FV3_GSD_SAR suite, change the suite to FV3_HRRR (since FV3_GSD_SAR is being removed).
… valid parameter values for CCPP_PHYS_SUITE and from the yaml FV3 namelist configuration file. Also, update comments in python scripts.
gsketefian
requested review from
mkavulich,
JeffBeck-NOAA,
RatkoVasic-NOAA,
BenjaminBlake-NOAA,
ywangwof,
chan-hoo,
panll,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
mark-a-potts,
jkbk2004,
willmayfield,
jwolff-ncar and
dmwright526
as code owners
mkavulich
approved these changes
Mar 15, 2022
JeffBeck-NOAA
approved these changes
Mar 15, 2022
gsketefian
added a commit
to ufs-community/ufs-srweather-app
that referenced
this pull request
Mar 15, 2022
…of regional_workflow (#224) ## DESCRIPTION OF CHANGES: This removes the old/unused physics suite `FV3_CPT_v0` from the list of suites to build. It also updates the hash of `regional_workflow` to include PR #[697](ufs-community/regional_workflow#697). ## TESTS CONDUCTED: Builds successfully on Hera. See PR #[697](ufs-community/regional_workflow#697) in the `regional_workflow` repo for WE2E tests conducted. ## DEPENDENCIES: This must be merged after PR #[697](ufs-community/regional_workflow#697) is merged in the `regional_workflow` repo.
mkavulich
added a commit
that referenced
this pull request
Mar 21, 2022
## DESCRIPTION OF CHANGES: Several paths in the machine-specific files point to locations in user paths or old locations of static data. This PR updates paths of static data in regional_workflow/ush/machine/ to point to the official, centralized locations on Cheyenne, Hera, and Jet. ## TESTS CONDUCTED: Ran the following suite of end-to-end tests on Cheyenne and Jet prior to the latest ufs-weather-model hash update. All passed. This list of tests was chosen because all of these tests are known to succeed on all tested platforms, and this tests a variety of input and boundary condition types. - grid_CONUS_25km_GFDLgrid_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16 - grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16 - grid_RRFS_CONUS_25km_ics_HRRR_lbcs_HRRR_suite_HRRR - grid_RRFS_CONUS_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta - grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_HRRR - grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta - grid_RRFS_CONUS_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta On Hera, I ran tests with the latest SRW hash, which included the updated weather model. Because of this, many tests could not be generated due to using old, removed CCPP suites (see issue #668). To get around this issue, I tested with the fixes from #697 incorporated into my branch. With those extra commits, all "get_extrn_ics" and "get_extrn_lbcs" tasks completed successfully, which indicates that all data is in its correct place. ## ISSUE (optional): Will resolve a few issues in #673, many remain however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOCUMENTATION:
This PR removes the
FV3_CPT_v0,FV3_GSD_v0, andFV3_GSD_SARsuites from the workflow. This consists of:CCPP_PHYS_SUITE,diag_table_...andfield_table_...files for these suites.grids_extrn_mdls_suites_communitycategory (which are tests to make sure that specific combinations of grids, external models, and suites work well together) that use these suites.wflow_featurescategory (get_from_HPSS_ics_HRRR_lbcs_RAP,get_from_HPSS_ics_RAP_lbcs_RAP, andspecify_DT_ATMOS_LAYOUT_XY_BLOCKSIZE) that happen to use theFV3_GSD_SARsuite such that they now use theFV3_HRRRsuite. (There are no such tests that use theFV3_CPT_v0andFV3_GSD_v0suites.) Note that we don't remove these tests because their purpose is not to test the suite but to test fetching of files from HPSS (get_from_HPSS_ics_HRRR_lbcs_RAPandget_from_HPSS_ics_RAP_lbcs_RAP) and to test that the experiment variablesDT_ATMOS,LAYOUT_X,LAYOUT_Y, andBLOCKSIZEcan be correctly specified in the user's experiment configuration file (specify_DT_ATMOS_LAYOUT_XY_BLOCKSIZEThis PR also makes improvements to the
tests/get_expts_status.shscript that is used to check the status of a set of experiments in a specified directory.DEPENDENCIES:
PR #224 in the
ufs-srweather-apprepo.TESTS CONDUCTED:
Ran the following tests on Hera:
All succeeded. Also, since the modifications to the
FV3.input.ymlfile affect theFV3_RRFS_v1alpha,FV3_RRFS_v1beta, andFV3_HRRRsuites, theinput.nmlfiles for these suites generated using the (original)developbranch were compared to the ones generated using this branch/PR, and all were found to be identical.ISSUE (optional):
Resolves Issue #668.