move diag_table and field_table from input data directory to parm directory in RT #653
Labels
enhancement
New feature or request
Comments
|
Is this duplicate of #644? |
|
Sorry, I was searching for the issue, but somehow missed it. Close the issue, thanks. |
epic-cicd-jenkins
pushed a commit
that referenced
this issue
Apr 17, 2023
## DESCRIPTION OF CHANGES: This PR is one of two in a series that addresses refactoring platform-dependence. The topic of this PR is to refactor the logic for supporting platforms with specific real-time data feeds. Here is a list of features and modifications that were made: - Apply appropriate style for functions, mainly related to white space for nested code and comments. - Make external model file offset hours configurable for analysis- and forecast-type files because sometimes we like to start a forecast from a forecast of another model. - Refactor to reduce duplication of information. - Set up filenames and paths to be specified with templates in a consistent way for every model instead of with bash logic that is different for every model's naming convention. - Remove paths that do not exist on platforms I have access to: Jet and Hera. No changes were made to the logic for input managed by USE_USER_STAGED_EXTRN_FILES or COMINGgfs for NCO mode, although it could make sense to re-assess the NCO mode handling at a later date. I plan to go through and "review" the code to lead reviewers through this one since it bit of change. It may be helpful to view it using GitHub's ignore whitespace feature. ## TESTS CONDUCTED: Test cases using the WE2E test on Hera; see PR for full list. A test case for the same forecast configuration using known paths on Hera to exercise the new code. I checked that arrays were consistent, that the script exits in a sane manner when files are not available on disk or HPSS, and that I haven't broken anything with the way files are handled through the "user specified" mechanism necessary for the test framework. ## ISSUE (optional): This work is an incremental change in support of Issue #618 ## CONTRIBUTORS (optional): @christopherwharrop-noaa @venitahagerty @robgonzalezpita
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
diag_table and field_table are model configuration related files, it's good to move these two table files in ufs-weather-model/tests/parm where the configuration files are located.
Solution
Move the diag_table and field_table to ufs-weather-model/tests/parm and update RT scripts to copy the corresponding files to test run directories.
Related to
Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related. Example:
The text was updated successfully, but these errors were encountered: