Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust GFS diagnostic Aerosol Optical Depth (AOD) output to the exact 550nm #1475

Merged
merged 15 commits into from
Nov 14, 2022

Conversation

ChunxiZhang-NOAA
Copy link
Contributor

@ChunxiZhang-NOAA ChunxiZhang-NOAA commented Oct 26, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

This PR is created to adjust the GFS diagnostic Aerosol Optical Depth (AD) output to the exact 550nm in FV3/ccpp/physics/physics/radiation_aerosols.f.

Issue(s) addressed

  • fixes #<15>

Testing

The RT was conducted on hera.intel. All cpld_* RTs will change baselines due to changed variables (_aod550) in sfcf.nc files.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

  • waiting on ufs-community/ccpp-physics/pull/<16>
  • waiting on noaa-emc/fv3atm/pull/<597>

@ChunxiZhang-NOAA ChunxiZhang-NOAA marked this pull request as ready for review October 31, 2022 16:26
@BrianCurtis-NOAA BrianCurtis-NOAA added the Baseline Updates Current baselines will be updated. label Nov 3, 2022
@jkbk2004
Copy link
Collaborator

@ChunxiZhang-NOAA We can start working on this pr. can you resolve the conflicts?

@ChunxiZhang-NOAA
Copy link
Contributor Author

@jkbk2004 Sure. I will make my branch update-to-date. I will let you know when it is ready.

@jkbk2004
Copy link
Collaborator

@ChunxiZhang-NOAA @BrianCurtis-NOAA I will let the RTs runs over weekend with baseline creation.

@ChunxiZhang-NOAA
Copy link
Contributor Author

ChunxiZhang-NOAA commented Nov 10, 2022

@jkbk2004 @BrianCurtis-NOAA Sounds a good plan. This branch is update-to-date and ready for the commit process.

@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Nov 10, 2022
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: orion
Compiler: intel
Job: BL
[BL] Repo location: /work/noaa/nems/emc.nemspara/autort/pr/1100942881/20221110204558/ufs-weather-model
Please make changes and add the following label back: orion-intel-BL

@jkbk2004
Copy link
Collaborator

For jenin-ci, there is work-in-progress to update input data file container. We will reactivate jenins-ci from next pr. @ChunxiZhang-NOAA @DusanJovic-NOAA @BrianCurtis-NOAA we can start merging process with final comments and approvals.

@ChunxiZhang-NOAA
Copy link
Contributor Author

@jkbk2004 May I merge ccpp-physics PR now?

@jkbk2004
Copy link
Collaborator

@jkbk2004 May I merge ccpp-physics PR now?

@ChunxiZhang-NOAA sure! please, go ahead to merge.

@ChunxiZhang-NOAA
Copy link
Contributor Author

ChunxiZhang-NOAA commented Nov 14, 2022

@jkbk2004 ccpp-physics PR has been merged. I've reverted the submodule pointer to ccpp-physics for fv3atm.

@jkbk2004
Copy link
Collaborator

@ChunxiZhang-NOAA OK! lets merge the pr here with hash update on fv3atm.

@ChunxiZhang-NOAA
Copy link
Contributor Author

@jkbk2004 Sure. I've reverted the pointer and updated the hash.

@jkbk2004 jkbk2004 merged commit 8d90fe7 into ufs-community:develop Nov 14, 2022
@ChunxiZhang-NOAA ChunxiZhang-NOAA deleted the bug/aod550 branch December 1, 2022 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants