Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for WAM physics and regression tests, remove duplicate modules from ccpp-physics CMakeLists.txt #947

Merged
Merged
Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
f195a1b
Update .gitmoduels submodule pointer for fv3atm for code review and t…
climbfuji Nov 23, 2021
a612a22
Update submodule pointer for fv3atm
climbfuji Nov 23, 2021
76bfa06
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
climbfuji Nov 29, 2021
9d3e6ee
Update submodule pointer for fv3atm
climbfuji Nov 29, 2021
692078f
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
climbfuji Dec 6, 2021
3d566f4
Update .gitmodules and submodule pointer for fv3atm for code review a…
climbfuji Dec 6, 2021
55351d1
Add WAM debug test
climbfuji Dec 6, 2021
166ea81
Merge branch 'rad_mp_diag_vars' of https://github.com/climbfuji/ufs-w…
climbfuji Dec 6, 2021
f30b1c8
Add blank line
climbfuji Dec 6, 2021
544cdd9
Update submodule pointer for fv3atm
climbfuji Dec 6, 2021
edcef20
Merge branch 'rad_mp_diag_vars' of https://github.com/climbfuji/ufs-w…
climbfuji Dec 6, 2021
99838b4
Update submodule pointer for fv3atm
climbfuji Dec 7, 2021
bf9d6df
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
climbfuji Dec 9, 2021
9e7b238
Update BL date in rt.sh, turn on tests that were turned off in the pr…
climbfuji Dec 9, 2021
be74582
Update submodule pointer for fv3atm
climbfuji Dec 10, 2021
bdca2d7
Update submodule pointer for fv3atm
climbfuji Dec 10, 2021
5be5ed2
RT JOBS PASSED: cheyenne.gnu. Log file uploaded.
BrianCurtis-NOAA Dec 10, 2021
49f74a9
Update submodule pointer for fv3atm one more time
climbfuji Dec 10, 2021
58ace8f
Merge branch 'rad_mp_diag_vars' of https://github.com/climbfuji/ufs-w…
climbfuji Dec 10, 2021
e287c05
Update submodule pointer for fv3atm AGAIN
climbfuji Dec 10, 2021
9c85e9b
Merge branch 'rad_mp_diag_vars' of https://github.com/climbfuji/ufs-w…
climbfuji Dec 10, 2021
0168ef6
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
climbfuji Dec 22, 2021
7e639c5
Use correct CNTL_DIR for test control_wam_debug
climbfuji Dec 22, 2021
1f3468b
Update submodule pointer for fv3atm
climbfuji Dec 22, 2021
27718b1
Update submodule pointer for fv3atm
climbfuji Dec 22, 2021
a779fcb
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
climbfuji Dec 29, 2021
f9c2c0e
Update submodule pointer for fv3atm
climbfuji Dec 29, 2021
e719fcd
Add missing diag_table entry to control_wam_debug, add control_wam_de…
climbfuji Dec 29, 2021
727f4d0
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
climbfuji Dec 29, 2021
1a8150a
RT JOBS PASSED: hera.gnu. Log file uploaded.
BrianCurtis-NOAA Dec 29, 2021
cfbb303
RT JOBS PASSED: orion.intel. Log file uploaded.
BrianCurtis-NOAA Dec 29, 2021
022ff49
RT JOBS PASSED: hera.intel. Log file uploaded.
BrianCurtis-NOAA Dec 29, 2021
5695ea8
RT JOBS PASSED: gaea.intel. Log file uploaded.
BrianCurtis-NOAA Dec 29, 2021
49c7b5a
RT JOBS PASSED: jet.intel. Log file uploaded.
BrianCurtis-NOAA Dec 29, 2021
840a298
Regression test log for wcoss_dell_p3
climbfuji Dec 30, 2021
6242455
RT JOBS PASSED: cheyenne.gnu. Log file uploaded.
BrianCurtis-NOAA Dec 30, 2021
528f849
RT JOBS PASSED: cheyenne.intel. Log file uploaded.
BrianCurtis-NOAA Dec 30, 2021
e601af0
Revert .gitmodules and update submodule pointer for fv3atm
climbfuji Dec 30, 2021
dce1467
Merge branch 'rad_mp_diag_vars_and_wam_bugfixes' of https://github.co…
climbfuji Dec 30, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
[submodule "FV3"]
path = FV3
url = https://github.com/NOAA-EMC/fv3atm
branch = develop
#url = https://github.com/NOAA-EMC/fv3atm
#branch = develop
url = https://github.com/climbfuji/fv3atm
branch = rad_mp_diag_vars_and_wam_bugfixes
[submodule "WW3"]
path = WW3
url = https://github.com/NOAA-EMC/WW3
Expand Down
2 changes: 1 addition & 1 deletion FV3
1,015 changes: 514 additions & 501 deletions tests/RegressionTests_gaea.intel.log

Large diffs are not rendered by default.

295 changes: 153 additions & 142 deletions tests/RegressionTests_hera.gnu.log

Large diffs are not rendered by default.

1,035 changes: 524 additions & 511 deletions tests/RegressionTests_hera.intel.log

Large diffs are not rendered by default.

929 changes: 471 additions & 458 deletions tests/RegressionTests_jet.intel.log

Large diffs are not rendered by default.

1,015 changes: 514 additions & 501 deletions tests/RegressionTests_orion.intel.log

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions tests/parm/wam.nml.IN
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
ncnst = 11
make_nh = @[MAKE_NH]
fv_debug = .false.
molecular_diffusion=.true.
molecular_diffusion=.true.
range_warn = .false.
reset_eta = .false.
n_sponge = -1
Expand Down Expand Up @@ -131,7 +131,7 @@
fhlwr = 3600.
ialb = 1
iems = 1
IAER = 111
IAER = @[IAER]
ico2 = 2
isubc_sw = 2
isubc_lw = 2
Expand Down Expand Up @@ -343,4 +343,3 @@
md_consv_te = 1.0
md_wait_hr = 0.0
/

11 changes: 7 additions & 4 deletions tests/rt.conf
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ RUN | rap_flake_debug
RUN | rap_noah_sfcdiff_cires_ugwp_debug | | fv3 |
RUN | rrfs_v1beta_debug | | fv3 |

COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_GFS_v16_fv3wam -D32BIT=ON -DMULTI_GASES=ON -DDEBUG=ON | | fv3 |
RUN | control_wam_debug | | fv3 |

###################################################################################################################################################################################
# HAFS tests #
###################################################################################################################################################################################
Expand All @@ -144,10 +147,10 @@ RUN | hafs_regional_atm
RUN | hafs_regional_atm_ocn | - wcoss2 | fv3 |
RUN | hafs_regional_atm_wav | - wcoss2 | fv3 |
RUN | hafs_regional_atm_ocn_wav | - wcoss2 | fv3 |
RUN | hafs_regional_1nest_atm | - jet.intel wcoss2 | fv3 |
RUN | hafs_regional_telescopic_2nests_atm | - jet.intel wcoss2 | fv3 |
RUN | hafs_global_1nest_atm | - jet.intel wcoss2 | fv3 |
RUN | hafs_global_multiple_4nests_atm | - jet.intel wcoss_cray wcoss2 | fv3 |
RUN | hafs_regional_1nest_atm | - jet.intel wcoss2 | fv3 |
RUN | hafs_regional_telescopic_2nests_atm | - jet.intel wcoss2 | fv3 |
RUN | hafs_global_1nest_atm | - jet.intel wcoss2 | fv3 |
RUN | hafs_global_multiple_4nests_atm | - jet.intel wcoss_cray wcoss2 | fv3 |

COMPILE | -DAPP=HAFS-ALL -DCCPP_SUITES=FV3_HAFS_v0_gfdlmp_tedmf,FV3_HAFS_v0_gfdlmp_tedmf_nonsst -D32BIT=ON | - wcoss_cray wcoss2 | fv3 |
RUN | hafs_regional_docn | - wcoss_cray wcoss2 | fv3 |
Expand Down
2 changes: 1 addition & 1 deletion tests/rt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ if [[ $TESTS_FILE =~ '35d' ]] || [[ $TESTS_FILE =~ 'weekly' ]]; then
TEST_35D=true
fi

BL_DATE=20211222
BL_DATE=20211229
if [[ $MACHINE_ID = hera.* ]] || [[ $MACHINE_ID = orion.* ]] || [[ $MACHINE_ID = cheyenne.* ]] || [[ $MACHINE_ID = gaea.* ]] || [[ $MACHINE_ID = jet.* ]] || [[ $MACHINE_ID = s4.* ]]; then
RTPWD=${RTPWD:-$DISKNM/NEMSfv3gfs/develop-${BL_DATE}/${RT_COMPILER^^}}
else
Expand Down
4 changes: 2 additions & 2 deletions tests/rt_gnu.conf
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ RUN | control_ras_debug
RUN | control_stochy_debug | | fv3 |
RUN | control_debug_p7 | | fv3 |

#COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_GFS_2017_fv3wam -D32BIT=ON -DMULTI_GASES=ON -DDEBUG=ON | | fv3 |
#RUN | fv3_multigases_debug | | fv3 |
COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_GFS_v16_fv3wam -D32BIT=ON -DMULTI_GASES=ON -DDEBUG=ON | | fv3 |
RUN | control_wam_debug | | fv3 |

##################################################################################################################################################################
# S2S tests #
Expand Down
8 changes: 6 additions & 2 deletions tests/tests/control_wam
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export SMONTH="03"
export SDAY="22"
export SHOUR="06"
export FHMAX=24

export WARM_START=.true.
export NA_INIT=0
export EXTERNAL_IC=.false.
Expand All @@ -28,12 +29,15 @@ export MAKE_NH=.false.
export MOUNTAIN=.true.
export FDIAG=3
export NSTF_NAME=0,0,1,0,5
export INPUT_NML=wam.nml.IN
export IAER=5111
export DO_SAT_ADJ=.false.

export FV3_RUN=wam_run.IN
export CCPP_SUITE=FV3_GFS_v16_fv3wam
export INPUT_NML=wam.nml.IN
export DIAG_TABLE=diag_table_wam
export FIELD_TABLE=field_table_wam
export IAER=5111

export QUILTING=.true.
export OUTPUT_GRID="gaussian_grid"
export OZ_PHYS_OLD=.false.
Expand Down
52 changes: 52 additions & 0 deletions tests/tests/control_wam_debug
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
###############################################################################
#
# Global control multigases debug test
#
###############################################################################

export TEST_DESCR="Compare global control multigases debug results with previous trunk version"

export CNTL_DIR=control_wam_debug

export LIST_FILES="sfcf019.nc \
junwang-noaa marked this conversation as resolved.
Show resolved Hide resolved
atmf019.nc"

export_fv3
export NPZ=149
export NPZP=150
export DT_ATMOS="225"
export SYEAR="2021"
export SMONTH="03"
export SDAY="22"
export SHOUR="06"

export FHMAX=19
export OUTPUT_FH="0 19"
#export WRITE_DOPOST=.true.

export WARM_START=.true.
export NA_INIT=0
export EXTERNAL_IC=.false.
export NGGPS_IC=.false.
export MAKE_NH=.false.
export MOUNTAIN=.true.
export FDIAG=3
export NSTF_NAME=0,0,1,0,5
export IAER=5111
export DO_SAT_ADJ=.false.

export FV3_RUN=wam_run.IN
export CCPP_SUITE=FV3_GFS_v16_fv3wam
export INPUT_NML=wam.nml.IN
export DIAG_TABLE=diag_table_wam
export FIELD_TABLE=field_table_wam

export QUILTING=.true.
export OUTPUT_GRID="gaussian_grid"
export OZ_PHYS_OLD=.false.
export OZ_PHYS_NEW=.true.
export H2O_PHYS=.true.
export NFHOUT=6
export NFHMAX=24
export NFHOUT_HF=6
export FHROT=18