Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v2.2.7) - WandB integration #306

Merged
merged 24 commits into from
Mar 20, 2023
Merged

(v2.2.7) - WandB integration #306

merged 24 commits into from
Mar 20, 2023

Conversation

AlejandroCN7
Copy link
Member

@AlejandroCN7 AlejandroCN7 commented Mar 16, 2023

Description

WandB integration in DRL_battery.py in order to make experiment track and registration simpler.

Motivation and Context

Charts works in the same way than tensorboard and hyperparameters track in MLflow.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Why is this change required? What problem does it solve? Please, reference issue or issues opened previously.

Fixes #172

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Added wandb extra dependency in setup.py.
  • Deleted mlflow and tensorboard dependencies and imports.
  • Adapted DRL_battery.py: Deleted mlflow and tensorboard functionality and integrated wandb.
  • Added WandBOutputFormat for callback loggers in SB3 (credits to @kad99kev).
  • Added wandb folder to gitignore.
  • Fixed log_intervalin JSON example.
  • Updated and enhanced DRL_battery.py structure.
  • Updated and enhanced load_agent.py structure.
  • Updated documentation (Weight and Bias instead of Tensorboard and MLflow).

@AlejandroCN7 AlejandroCN7 marked this pull request as ready for review March 20, 2023 12:20
@AlejandroCN7 AlejandroCN7 merged commit ea4bb91 into main Mar 20, 2023
@AlejandroCN7 AlejandroCN7 deleted the feat/issue-172 branch March 20, 2023 14:00
@AlejandroCN7 AlejandroCN7 mentioned this pull request Mar 28, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: "Weights & Biases" integration
1 participant