Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v(3.3.4) - NormalizeObservation calibration load improvement #413

Merged
merged 5 commits into from
May 9, 2024

Conversation

AlejandroCN7
Copy link
Member

Description

This PR enhances the loading of previous normalization calibrations for model evaluations. It now allows specifying paths to txt files generated by Sinergym.

Additionally, this patch includes improved checks and error messages when performing these loads.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • NormalizeObservation Wrapper: Added txt path file option in constructor.
  • Unified len mean and var assert, use the same checks in setters.
  • Update documentation and drl notebook with this functionality

Extra:

  • Included some get_wrapper_attr in sinergym tests.

@AlejandroCN7 AlejandroCN7 merged commit 9e77c17 into main May 9, 2024
5 checks passed
@AlejandroCN7 AlejandroCN7 deleted the impr/normalization_load branch May 9, 2024 11:02
@AlejandroCN7 AlejandroCN7 changed the title v(3.3.4) - NoprmalizeObservation calibration load improvement v(3.3.4) - NormalizeObservation calibration load improvement May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant