Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.3.6) - Sinergym normalization fix for DRL evaluations and new Ubuntu and Python version #419

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

AlejandroCN7
Copy link
Member

@AlejandroCN7 AlejandroCN7 commented Jun 27, 2024

Description

When an experiment is conducted using the evaluation callback, the evaluations during intermediate learning processes do not use the learned calibration of normalized variables from the training and instead update on their own.

For an evaluation, the model should use the same calibration (without updating) and start from the values at the point where the training is interrupted. This patch fixes that functionality to ensure this happens.

Due to the recent update from the opyplus package, as mentioned in issue #418, this update caused an error by breaking the dependency system on internal packages. The calls to these packages with new names in Sinergym have been fixed.

Since this update made opyplus compatible with new Python versions, we have taken advantage of this update to become compatible with the new versions of Ubuntu and Python (24.04 and 3.12.3), making us officially compatible.

Fixes #418

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Fix EvalLoggerCallback for deactivate normalization update and update mean and var calibration from training env automatically (when NormalizeObservation was activated)
  • Fix opyplus update inconsistency.
  • Dockerfile: Updated Ubuntu and Python version (24.04 and 3.12.3)
  • Added version documentation

@AlejandroCN7 AlejandroCN7 merged commit 9c37c2d into main Jun 27, 2024
5 checks passed
@AlejandroCN7 AlejandroCN7 deleted the feat/fix-normalization branch June 27, 2024 10:59
@AlejandroCN7 AlejandroCN7 changed the title (v3.3.6) - Sinergym normalization fix for DRL evaluations (v3.3.6) - Sinergym normalization fix for DRL evaluations and new Ubuntu and Python version Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Question]: New opyplus release seems to break sinergym import
1 participant