-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(v3.5.7) - Weather variability in any of its data #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in constructor and method call
…tionary format with several variables
…ctionary dict directly
…parameters function
…with variation are checked
…mock configuration
…lity definition and updated env test
…ection and environment registration section
AlejandroCN7
changed the title
(v3.5.6) - Weather variability in any of its data
(v3.5.7) - Weather variability in any of its data
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So far, the method responsible for applying OU noise to the climate had the ability to be used on any of the weather columns, allowing it to be applied to other aspects, not just outdoor temperature. However, this feature was not being fully utilized.
To address this, not only has the method's input been updated, but the definition of environments and how they are automatically registered has also been modified. This allows users to define, column by column, what type of variation is applied in the EPW file in every episode.
It’s very easy to use, and the documentation and tests have been updated for easy reference. Additionally, a few minor corrections have also been applied. For more information, check the changelog and commits.
Motivation and Context
Fixes #433
Types of changes
Checklist:
autopep8
second level aggressive.isort
.cd docs && make spelling && make html
pass (required if documentation has been updated.)pytest tests/ -vv
pass. (required).pytype -d import-error sinergym/
pass. (required)Changelog: