Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.5.7) - Weather variability in any of its data #440

Merged
merged 21 commits into from
Sep 10, 2024
Merged

Conversation

AlejandroCN7
Copy link
Member

Description

So far, the method responsible for applying OU noise to the climate had the ability to be used on any of the weather columns, allowing it to be applied to other aspects, not just outdoor temperature. However, this feature was not being fully utilized.

To address this, not only has the method's input been updated, but the definition of environments and how they are automatically registered has also been modified. This allows users to define, column by column, what type of variation is applied in the EPW file in every episode.

It’s very easy to use, and the documentation and tests have been updated for easy reference. Additionally, a few minor corrections have also been applied. For more information, check the changelog and commits.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Fixes #433

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Default configurations: Updated weather noise specification.
  • Updated weather_noise to weather_variability name in default configurations.
  • eplus_env.py: Specify directly a weather_variability dict new format in constructor and method call.
  • Added common level in terminal logger.
  • Added mock new configuration exception with variability
  • Documentation, notebooks and tests updated.

@AlejandroCN7 AlejandroCN7 self-assigned this Sep 10, 2024
@AlejandroCN7 AlejandroCN7 added the building Buildings (IDF, EPW) label Sep 10, 2024
@AlejandroCN7 AlejandroCN7 changed the title (v3.5.6) - Weather variability in any of its data (v3.5.7) - Weather variability in any of its data Sep 10, 2024
@AlejandroCN7 AlejandroCN7 merged commit 0d9a001 into main Sep 10, 2024
4 checks passed
@AlejandroCN7 AlejandroCN7 deleted the feat/issue-433 branch September 10, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Buildings (IDF, EPW)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Use noise in other weather components than drybulb temperature
1 participant