Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.5.9) - Action delay fix #443

Merged
merged 10 commits into from
Sep 14, 2024
Merged

(v3.5.9) - Action delay fix #443

merged 10 commits into from
Sep 14, 2024

Conversation

AlejandroCN7
Copy link
Member

@AlejandroCN7 AlejandroCN7 commented Sep 13, 2024

Description

This PR solves commented bug in referenced issue (and similar ones). Now, Sinergym actions take effect in the next step immediately.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Fixes #436

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Simulator: Fix step delay in simulator: Avoiding to skip action process in reset. Managing queue block in a different way for actions.
  • LoggerStorage: Added methods to log observation and info independently (for reset).
  • Logger wrappers: Adapt wrappers for reset registration.
  • CSVLogger: Added fix for save actions in csv as list instead of numpy array.

@AlejandroCN7 AlejandroCN7 mentioned this pull request Sep 13, 2024
3 tasks
@AlejandroCN7 AlejandroCN7 merged commit 89ee599 into main Sep 14, 2024
4 checks passed
@AlejandroCN7 AlejandroCN7 deleted the bug/issue-436 branch September 14, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Action Repetition Issue
1 participant