From 7de37aea400047cf4b9859a5af68707580be690f Mon Sep 17 00:00:00 2001
From: "J. Nick Koston" <nick@koston.org>
Date: Thu, 4 Jul 2024 11:45:56 -0500
Subject: [PATCH] chore: add test coverage for chime type (#143)

---
 tests/data/test_camera.py | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/tests/data/test_camera.py b/tests/data/test_camera.py
index 0632f498..519a5449 100644
--- a/tests/data/test_camera.py
+++ b/tests/data/test_camera.py
@@ -11,6 +11,7 @@
 from tests.conftest import TEST_CAMERA_EXISTS
 from uiprotect.data import (
     Camera,
+    ChimeType,
     DoorbellMessageType,
     HDRMode,
     IRLEDMode,
@@ -482,6 +483,32 @@ async def test_camera_set_chime_duration_no_chime(camera_obj: Camera | None):
     assert not camera_obj.api.api_request.called
 
 
+@pytest.mark.skipif(not TEST_CAMERA_EXISTS, reason="Missing testdata")
+@pytest.mark.asyncio()
+async def test_camera_mechanical_chime(
+    camera_obj: Camera | None,
+):
+    if camera_obj is None:
+        pytest.skip("No camera_obj obj found")
+    camera_obj.feature_flags.has_chime = True
+    camera_obj.chime_duration = timedelta(seconds=0.3)
+    assert camera_obj.chime_duration_seconds == 0.3
+    assert camera_obj.chime_type is ChimeType.MECHANICAL
+
+
+@pytest.mark.skipif(not TEST_CAMERA_EXISTS, reason="Missing testdata")
+@pytest.mark.asyncio()
+async def test_camera_no_chime(
+    camera_obj: Camera | None,
+):
+    if camera_obj is None:
+        pytest.skip("No camera_obj obj found")
+    camera_obj.feature_flags.has_chime = True
+    camera_obj.chime_duration = timedelta(seconds=0)
+    assert camera_obj.chime_duration_seconds == 0
+    assert camera_obj.chime_type is ChimeType.NONE
+
+
 @pytest.mark.skipif(not TEST_CAMERA_EXISTS, reason="Missing testdata")
 @pytest.mark.parametrize("duration", [-1, 0, 0.5, 1, 20])
 @pytest.mark.asyncio()
@@ -497,6 +524,7 @@ async def test_camera_set_chime_duration_duration(
     camera_obj.feature_flags.has_chime = True
     camera_obj.chime_duration = timedelta(seconds=300)
     assert camera_obj.chime_duration_seconds == 300
+    assert camera_obj.chime_type is ChimeType.DIGITAL
     camera_obj.mic_volume = 10
 
     if duration in {-1, 20}: