NTBS-2074: Fix sentry warnings #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshCadney
reviewed
Mar 11, 2021
JoshCadney
reviewed
Mar 16, 2021
JoshCadney
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have fixed 3 warnings/errors we were getting on sentry due to the .NET upgrade.
Our heartbeat code wasn't checking for null, which meant if we hadn't set a "latest activity time" it would throw an error when trying to compare it. I have set this to default to true.
I have added query splitting where I had missed it previously.
I have fixed a warning about using skip/take without ordering. This one is a sort of "bug" in .NET, where using query splitting results in needing an orderby. (link to issue: dotnet/efcore#23803).
Checklist: