Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting after quitting with tabs doesn't restore focus #250

Closed
valankar opened this issue Apr 7, 2024 · 2 comments
Closed

Restarting after quitting with tabs doesn't restore focus #250

valankar opened this issue Apr 7, 2024 · 2 comments
Labels
bug Something isn't working modalkit Issues that require an accompanying modalkit change ui Issues related to rendering, widgets, or general terminal-related issues
Milestone

Comments

@valankar
Copy link

valankar commented Apr 7, 2024

I have 2 tabs:

  1. DM
  2. Room

In my settings I have:

[settings]
default_room = "room from 2 above"

If I am focused on tab 2, quit the app with :qa, and restart, it restarts focused on tab 1. I think it should restart with tab 2 focused. I'm not sure if default_room is doing anything in this case. Thanks.

@ulyssa
Copy link
Owner

ulyssa commented Apr 8, 2024

Yep, this is something that should be improved. The focused tab and window information don't get worn out at the moment.

default_room is used when style = "new" in [layout]. (See here.)

@ulyssa ulyssa added bug Something isn't working ui Issues related to rendering, widgets, or general terminal-related issues modalkit Issues that require an accompanying modalkit change labels Apr 8, 2024
@ulyssa ulyssa added this to the v0.0.10 milestone Aug 12, 2024
@ulyssa
Copy link
Owner

ulyssa commented Aug 12, 2024

This was fixed by @Andrew-Collins in ulyssa/modalkit#143. I have updated the modalkit-ratatui dependency to pull it in in #319.

@ulyssa ulyssa closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working modalkit Issues that require an accompanying modalkit change ui Issues related to rendering, widgets, or general terminal-related issues
Projects
None yet
Development

No branches or pull requests

2 participants