Avoid treating simple messages as Markdown #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssa
force-pushed
the
markdown-convert-skip
branch
from
93b23ee
to
456fa6f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first stab at improving the issue reported in #306 by not generating a
formatted_bodyunless the text actually contains Markdown. I've done this for now based on characters used, which largely ends up meaning "doesn't contain ASCII punctuation" except for single and double quotes which are okay.There's still some room for improvement in a future PR: Element will generate a
formatted_bodywithout surrounding<p>tags as long as everything fits on one line. While the<p>tags should be harmless, it seems like some clients will show them with trailing space in the timeline, which makes messages sent from iamb take up additional space. (This seems to be most egregious in Element Android. Element Web, Element iOS and FluffyChat don't seem to add any extra space that I notice compared to the Element Android screenshot shared in#iamb-users:0x.badd.cafe. )