-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the version requirements for running the current back office #13940
Updated the version requirements for running the current back office #13940
Conversation
Building the current version of the back office is only supported on Node v16 and earlier so have updated the docs to reflect that.
Hi there @richarth, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
For v11 you now need to be running .Net 7 and VS 2022 so have updated the docs to reflect that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @richarth, thanks for updating this, it is an interesting one...
Node v16.19.1 is required to run the tests, but just running the build-only gulp tasks works all the way up to v19.7.0 (current latest version).
When running the frontend build as part of the default (.NET/C#) project build the tests are skipped, so there is still no upper limit when it comes to "building" Umbraco from source.
If you think it would be helpful, perhaps you could add a separate note in here about the node version required for running the tests?
Assuming this PR gets merged, the gulp tests (and default gulp build) will then work on all Node.js versions from 14 to 19. |
Co-authored-by: Jason Elkin <jasonelkin86@gmail.com>
Thanks both @richarth for helping with the updates and @JasonElkin for fixing #13968 so that the requirements span a nice wide range of node versions again. Much nicer to be able to support the latest LTS of node! |
FYI: I've not put any additional labels on, this is an update that only affects contributors, not an actual Umbraco release. Thanks again! |
Thanks @JasonElkin and @nul800sebastiaan for fixing this. It's going to make getting started contributing much smoother. |
Building the current version of the back office is only supported on Node v16 and earlier so have updated the docs to reflect that.