V14: Remove legacy manifest parser #15744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolajlauridsen
added
category/breaking
project/bellissima
|
Note symptom will be: This presumably affects many packages and it will be unclear from the error message which package is using an |
…acy-package-manifest # Conflicts: # src/Umbraco.Core/ContentApps/ContentEditorContentAppFactory.cs # src/Umbraco.Core/ContentApps/ListViewContentAppFactory.cs # src/Umbraco.Core/Models/ContentEditing/ContentItemDisplay.cs # tests/Umbraco.Tests.UnitTests/Umbraco.Core/Manifest/LegacyManifestParserTests.cs # tests/Umbraco.Tests.UnitTests/Umbraco.Web.BackOffice/Controllers/MemberControllerUnitTests.cs
|
I think that error is related to d2ed03a - I know it sucks, but it have been like that long time before the first preview. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the legacy manifest parser and the files that were dependant on it.
This includes all of the ContentApp, Sections, and Dashboard related services and models, this is now purely a frontend concern.
Breaking
This of course very breaking, these things now needs to be registered through the frontend